On Mon, May 02, 2016 at 09:54:02AM -0600, Jon Derrick wrote: > This patch changes the use_cmb_sqes module parameter to read-only. This > parameter allows the driver to place IO submission queues within the > Controller Memory Buffer. The parameter is currently writable through > sysfs at /sys/module/nvme/parameters/use_cmb_sqes. > > Memory allocations for queues aren't dynamically reallocated between > resets. For this reason, allowing the use_cmb_sqes module parameter to > be written while the drive is loaded may be confusing because we have no > mechanism to dynamically remap the queues. I agree, so: Reviewed-by: Christoph Hellwig <hch@xxxxxx> But re-reviewing this again I really hate the whole idea of the user having to chose what to do with the CMB. Can you just add a quirk to do the right thing for the controller(s) you care about, and work with the NVMe TWG to have a standardized way for the controllers to give this information to the host? -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
