-------- Forwarded Message -------- Subject: Re: [PATCH] block: loop: fix filesystem corruption in case of aio/dio Date: Fri, 15 Apr 2016 21:16:42 +0800 From: Ming Lei <ming.lei@xxxxxxxxxxxxx> To: Holger Hoffstätte <holger.hoffstaette@xxxxxxxxxxxxxx> On Fri, Apr 15, 2016 at 8:51 PM, Holger Hoffstätte <holger.hoffstaette@xxxxxxxxxxxxxx> wrote: > (off-list since I'm likely missing something..) > > Hello Ming Lei, > > quick question - > > On 04/15/16 12:51, Ming Lei wrote: >> Starting from commit e36f620428(block: split bios to max possible length), >> block core starts to split bio in the middle of bvec. >> >> Unfortunately loop dio/aio doesn't consider this situation, and >> always treat 'iter.iov_offset' as zero. Then filesystem corruption >> is observed. >> >> This patch figures out the offset of the base bvevc via >> 'bio->bi_iter.bi_bvec_done' and fixes the issue by passing the offset >> to iov iterator. >> >> Fixes: e36f6204288088f (block: split bios to max possible length) >> Cc: Keith Busch <keith.busch@xxxxxxxxx> >> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx> >> Cc: stable@xxxxxxxxxxxxxxx (4.5) > ^^^^^ > > The previous patch went into 4.4.x-stable, so should this one not go > into 4.4.x as well? It applies cleanly and does not seem to hurt. > Apologies in advance if this is a bad idea. :) You are absolutely right, this patch should have been marked as stable 4.4+, thanks for point it out! Jens, please let me know if you need me to resend the patch for fixing the stable tag. Thanks, Ming -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
