>>>>> "Bart" == Bart Van Assche <bart.vanassche@xxxxxxxxxxx> writes: Bart> And if so, how should this code behave and if sector and/or Bart> nr_sectors is not a multiple of sdp->sector_size? As one can see Bart> the above code rounds down sector and nr_sectors while converting Bart> from sectors to logical blocks. This means that if a non-aligned Bart> BLKDISCARD is submitted from user space that one or more sectors Bart> *before* the start of the range specified in the ioctl will be Bart> discarded. Isn't that a bug? Yes. But Darrick already addressed that, I believe. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
