Re: [PATCH] badblocks: fix wrong return value when badblocks are disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2016-04-05 at 14:59 +0200, Artur Paszkiewicz wrote:
> The return value of md_set_badblocks() was inverted when the code was
> taken out of md, but the case when badblocks are disabled was left
> unchanged. This causes silent ignoring of I/O errors and other
> unpredictable behavior on md arrays that do not support badblocks (any
> array not using v1.x metadata).
> 
> Fixes: 9e0e252a048b ("badblocks: Add core badblock management code")
> Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@xxxxxxxxx>
> ---
>  block/badblocks.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Good find, thanks!

Acked-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>

Should this also be tagged for stable?

	-Vishal
��.n��������+%������w��{.n�����{����n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�

[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux