On 04/01/2016 08:34 AM, Sudip Mukherjee wrote:
We were checking for iter to be NULL after dereferencing it. There is actually no need to check for iter to be NULL as all the callers of blk_rq_map_user_iov() does call it with a valid pointer to struct iov_iter. But as iter->count can be NULL so the assignment to copy is being done after checking for it. Signed-off-by: Sudip Mukherjee <sudip.mukherjee@xxxxxxxxxxxxxxx> --- v2: removed the check for iter v1: moved the assignment to copy after check for iter and iter->count
Your subject is wrong (there's no NULL deref). Ditto for the commit message - it can be zero, not NULL. The latter would imply a memory address, but it's just an integer.
-- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
