> + nr_pages = BIO_MAX_PAGES; > if (nr_pages > total_nr_pages) > nr_pages = total_nr_pages; Looks reasonable, but the whole thing could simply become: nr_pages = min(total_nr_pages, BIO_MAX_PAGES); -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html