Christoph Hellwig <hch@xxxxxx> writes: > On Tue, Mar 15, 2016 at 10:15:39AM -0400, Jeff Moyer wrote: >> Hannes Reinecke <hare@xxxxxxx> writes: >> >> > We need to check for a valid index before accessing the array >> > element to avoid accessing invalid memory regions. >> >> Hi, Hannes, >> >> What's the motivation here? Did you witness an invalid tag being passed >> in? Isn't that just a bug in the caller? > > The tag generally comes more or less straight from the wire. So > someome should bounds check it, and doing it in one place seems easier > than in every driver, and Hannes patch would allow us to remove these > checks from nvme. OK, thanks for the explanation. Looks fine to me, then. Reviewed-by: Jeff Moyer <jmoyer@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
