On Mon, Feb 15, 2016 at 4:22 PM, Sagi Grimberg <sagig@xxxxxxxxxxxxxxxxxx> wrote:
>
>> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
>> index 4571ef1..b8ff6a3 100644
>> --- a/include/linux/blkdev.h
>> +++ b/include/linux/blkdev.h
>> @@ -1388,7 +1388,7 @@ static inline bool bvec_gap_to_prev(struct
>> request_queue *q,
>> static inline bool bio_will_gap(struct request_queue *q, struct bio
>> *prev,
>> struct bio *next)
>> {
>> - if (!bio_has_data(prev))
>> + if (!bio_has_data(prev) || !queue_virt_boundary(q))
>> return false;
>
>
> Can we not do that?
Given there are only 3 drivers which set virt boundary, I think
it is reasonable to do that.
>
> bvec_gap_to_prev is already checking the virt_boundary and I'd sorta
> like to keep the motivation to optimize bio_get_last_bvec() to be O(1).
Currently the approaches I thought of still need to iterate bvec by bvec,
not sure if O(1) can be reached easily, but I am happy to discuss the
optimized implementation.
Thanks,
Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
