[PATCH] block: blkg_conf_finish fix module refcount

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Chang Huaixin <huaixin.chx@xxxxxxxxxxxxxxx>

Blkg_conf_finish is used after blkg_conf_prep.

Blkg_conf_prep calls get_disk and increases module refcount. However,
blkg_conf_finish only calls put_disk which doesn't decrease module refcount.
So we call module_put here additionally to keep module refcount balanced.

Signed-off-by: Chang Huaixin <huaixin.chx@xxxxxxxxxxxxxxx>
---
 block/blk-cgroup.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 5a37188..15cbf36 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -853,6 +853,7 @@ void blkg_conf_finish(struct blkg_conf_ctx *ctx)
 {
 	spin_unlock_irq(ctx->disk->queue->queue_lock);
 	rcu_read_unlock();
+	module_put(ctx->disk->fops->owner);
 	put_disk(ctx->disk);
 }
 EXPORT_SYMBOL_GPL(blkg_conf_finish);
-- 
1.9.4

--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux