On 01/25/2016 07:13 AM, Stefan Haberland wrote:
Am 23.01.2016 um 04:44 schrieb Jens Axboe:
On 01/22/2016 05:05 PM, Ming Lei wrote:
After commit e36f62042880(block: split bios to maxpossible length),
bio can be splitted in the middle of a vector entry, then it
is easy to split out one bio which size isn't aligned with block
size, especially when the block size is bigger than 512.
This patch fixes the issue by making the max io size aligned
to logical block size.
Fixes: e36f62042880(block: split bios to maxpossible length)
Reported-by: Stefan Haberland <sth@xxxxxxxxxxxxxxxxxx>
Cc: Keith Busch <keith.busch@xxxxxxxxx>
Suggested-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Ming Lei <tom.leiming@xxxxxxxxx>
---
V1:
- avoid double shift as suggested by Linus
- compute 'max_sectors' once as suggested by Keith
This looks good to me, I'll apply and run a bit of local testing.
I applied the patch and it seems to work for DASD devices. I will do
some more testing but for me it looks OK.
Thanks for testing, Stefan. It'll go into mainline pretty soon.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
