On Fri, Jan 22, 2016 at 10:43:59AM -0800, Linus Torvalds wrote: > On Fri, Jan 22, 2016 at 10:29 AM, Ming Lei <tom.leiming@xxxxxxxxx> wrote: > > > > This patch fixes the issue by making the max io size aligned > > to logical block size. > > Looks better, thanks. > > I'd suggest also moving the "max_sectors" variable into the > bio_for_each_segment() loop too just to keep variables with minimal > scope, but at least this is fairly legible. The value of max_sectors doesn't change in this function, so its calculation could be done just once instead of with each segment iteration. Other than that, thanks Ming, the fix looks good to me. Third try's a charm? -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
