Re: [PATCH RFC 3/4] nvme: Move IO termination code to the core

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +void nvme_fail_admin_cmds(struct nvme_ctrl *ctrl,
> +		busy_tag_iter_fn *terminate_io, void *priv)
> +{
> +	blk_mq_tagset_busy_iter(ctrl->admin_tagset, terminate_io, priv);
> +}
> +EXPORT_SYMBOL_GPL(nvme_fail_admin_cmds);
> +
> +void nvme_fail_io_cmds(struct nvme_ctrl *ctrl,
> +		busy_tag_iter_fn *terminate_io, void *priv)
> +{
> +	blk_mq_tagset_busy_iter(ctrl->tagset, terminate_io, priv);
> +}
> +EXPORT_SYMBOL_GPL(nvme_fail_io_cmds);

But I see absolutely no point for these helpers.  These are trivial
one-liners that can stay in the transport drivers.  And with that we
also don't need the admin_tagset pointer in the generic controller
(at least yet..)
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux