On Wed, 2015-11-25 at 11:43 -0700, Vishal Verma wrote: > v2: > - In badblocks_free, make 'page' NULL (patch 1) > - Move the core badblocks code to a new .c file (patch 1) (Jens) > - Fix a sizeof usage in disk_alloc_badblocks (patch 2) (Dan) > - Since disk_alloc_badblocks can fail, check disk->bb for NULL in > the > genhd wrappers (patch 2) (Jeff) > - Update the md conversion to also ise the badblocks init and free > functions (patch 3) > - Remove the BB_* macros from md.h as they are now in badblocks.h > (patch 3) > > Patch 1 copies badblock management code into a header of its own, > making it generally available. It follows common libraries of code > such as linked lists, where anyone may embed a core data structure > in another place, and use the provided accessor functions to > manipulate the data. > > Patch 2 adds badblock tracking to gendisks (in preparation for use > by NVDIMM devices). Right now, it is turned on unconditionally - I'd > appreciate comments on if that is the right path. > > Patch 3 converts md over to use the new badblocks 'library'. I have > done some pretty simple testing on this - created a raid 1 device, > made sure the sysfs entries show up, and can be used to add and view > badblocks. A closer look by the md folks would be nice here. > > > Vishal Verma (3): > badblocks: Add core badblock management code > block: Add badblock management for gendisks > md: convert to use the generic badblocks code > Ping. Jens, are you ok taking this through the block tree? Any other comments from anyone else? Thanks, -Vishal��.n��������+%������w��{.n�����{����n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�