Christoph Hellwig <hch@xxxxxx> writes: > On Mon, Nov 23, 2015 at 03:31:32PM -0500, Jeff Moyer wrote: >> I don't see where the blk-mq timeout work is ever scheduled. You >> removed the call to setup_timer for the mq case, so what causes the mq >> timeout work to run? I must be missing something. > > No we use the timer which we initialize in blk_alloc_queue_node instead > of overwriting it later in the blk-mq case. The timer gets added in > blk_add_timer either way. Ah, I see. I missed the call to blk_alloc_queue_node from blk_mq_init_queue. Thanks. The patch looks good to me. Everything will still be running in the same context (irqs off). Reviewed-by: Jeff Moyer <jmoyer@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
