Re: nvme lightnvm comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Christoph,

On 11/20/2015 11:50 AM, Christoph Hellwig wrote:
Hi Matias,

two small comments on the NVME lighnvm support:

  1) please don't claim the existing Qemu NVMe PCI ID for lightnvm
     support.  We might need the actual vendor specific data for
     qemu purposes.  Please allocate a different PCI ID for a qemu
     emulated lightnvm nvme device

I'll look into it.

  2) please build the lightnvm.o object conditionally in the makefile

Then the functions

nvme_nvm_register
nvme_nvm_unregister
nvme_nvm_register

have to be #ifdef'ed in the pci file. Do you want that instead? It was on purpose the other way around, so that the nvme_nvm_* functions was null functions if lightnvm isn't compiled in.


Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux