Maybe it'd be better to split this to two patches. 1. pass ctrl to enable/disable/shutdown_ctrl 2. move enable/disable/shutdown_ctrl to common code Other then that looks good. -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html