> 2024年12月2日 19:56，Coly Li <colyli@xxxxxxx> 写道：
>
> From: Liequan Che <cheliequan@xxxxxxxxxx>
>
> Commit 028ddcac477b ("bcache: Remove unnecessary NULL point check in
> node allocations") leads a NULL pointer deference in cache_set_flush().
>
> 1721 if (!IS_ERR_OR_NULL(c->root))
> 1722 list_add(&c->root->list, &c->btree_cache);
>
> From the above code in cache_set_flush(), if previous registration code
> fails before allocating c->root, it is possible c->root is NULL as what
> it is initialized. __bch_btree_node_alloc() never returns NULL but
> c->root is possible to be NULL at above line 1721.
>
> This patch replaces IS_ERR() by IS_ERR_OR_NULL() to fix this.
>
> Fixes: 028ddcac477b ("bcache: Remove unnecessary NULL point check in node allocations")
> Signed-off-by: Liequan Che <cheliequan@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Cc: Zheng Wang <zyytlz.wz@xxxxxxx>
> Reviewed-by: Mingzhe Zou <mingzhe.zou@xxxxxxxxxxxx>
> Signed-off-by: Coly Li <colyli@xxxxxxx>
> ---
> drivers/md/bcache/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Hi Jens,
Could you please take this patch? It is tiny change but important, and good to have it in next rc release.
Thank you in advance.
Coly Li
