Hi, kernel test robot noticed the following build errors: [auto build test ERROR on next-20241121] [also build test ERROR on v6.12] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/mingzhe-zou-easystack-cn/bcache-fix-io-error-during-cache-read-race/20241121-142652 base: next-20241121 patch link: https://lore.kernel.org/r/20241119032852.2511-2-mingzhe.zou%40easystack.cn patch subject: [PATCH 2/3] bcache: fix io error during cache read race config: arm-randconfig-001-20241122 (https://download.01.org/0day-ci/archive/20241122/202411220826.WbtAugHL-lkp@xxxxxxxxx/config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241122/202411220826.WbtAugHL-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202411220826.WbtAugHL-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): >> drivers/md/bcache/request.c:573:55: error: no member named 'sb' in 'struct cache_set' 573 | pr_warn("%pU cache read race count: %lu", s->iop.c->sb.set_uuid, | ~~~~~~~~ ^ include/linux/printk.h:554:37: note: expanded from macro 'pr_warn' 554 | printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~~ include/linux/printk.h:501:60: note: expanded from macro 'printk' 501 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__) | ^~~~~~~~~~~ include/linux/printk.h:473:19: note: expanded from macro 'printk_index_wrap' 473 | _p_func(_fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ 1 error generated. vim +573 drivers/md/bcache/request.c 520 521 /* 522 * Read from a single key, handling the initial cache miss if the key starts in 523 * the middle of the bio 524 */ 525 static int cache_lookup_fn(struct btree_op *op, struct btree *b, struct bkey *k) 526 { 527 struct search *s = container_of(op, struct search, op); 528 struct bio *n, *bio = &s->bio.bio; 529 struct bkey *bio_key; 530 531 if (bkey_cmp(k, &KEY(s->iop.inode, bio->bi_iter.bi_sector, 0)) <= 0) 532 return MAP_CONTINUE; 533 534 if (KEY_INODE(k) != s->iop.inode || 535 KEY_START(k) > bio->bi_iter.bi_sector) { 536 unsigned int bio_sectors = bio_sectors(bio); 537 unsigned int sectors = KEY_INODE(k) == s->iop.inode 538 ? min_t(uint64_t, INT_MAX, 539 KEY_START(k) - bio->bi_iter.bi_sector) 540 : INT_MAX; 541 int ret = s->d->cache_miss(b, s, bio, sectors); 542 543 if (ret != MAP_CONTINUE) 544 return ret; 545 546 /* if this was a complete miss we shouldn't get here */ 547 BUG_ON(bio_sectors <= sectors); 548 } 549 550 if (!KEY_SIZE(k)) 551 return MAP_CONTINUE; 552 553 atomic_inc(&PTR_BUCKET(s->iop.c, k, 0)->pin); 554 555 PTR_BUCKET(b->c, k, 0)->prio = INITIAL_PRIO; 556 557 n = bio_next_split(bio, min_t(uint64_t, INT_MAX, 558 KEY_OFFSET(k) - bio->bi_iter.bi_sector), 559 GFP_NOIO, &s->d->bio_split); 560 561 retry: 562 /* 563 * If the bucket was reused while our bio was in flight, we might have 564 * read the wrong data. Set s->cache_read_races and reread the data 565 * from the backing device. 566 */ 567 if (ptr_stale(s->iop.c, k, 0)) { 568 if (PTR_BUCKET(b->c, k, 0)->invalidating) 569 goto retry; 570 571 atomic_dec(&PTR_BUCKET(s->iop.c, k, 0)->pin); 572 atomic_long_inc(&s->iop.c->cache_read_races); > 573 pr_warn("%pU cache read race count: %lu", s->iop.c->sb.set_uuid, 574 atomic_long_read(&s->iop.c->cache_read_races)); 575 576 n->bi_end_io = backing_request_endio; 577 n->bi_private = &s->cl; 578 579 /* I/O request sent to backing device */ 580 closure_bio_submit(s->iop.c, n, &s->cl); 581 return n == bio ? MAP_DONE : MAP_CONTINUE; 582 } 583 584 bio_key = &container_of(n, struct bbio, bio)->key; 585 bch_bkey_copy_single_ptr(bio_key, k, 0); 586 587 bch_cut_front(&KEY(s->iop.inode, n->bi_iter.bi_sector, 0), bio_key); 588 bch_cut_back(&KEY(s->iop.inode, bio_end_sector(n), 0), bio_key); 589 590 n->bi_end_io = bch_cache_read_endio; 591 n->bi_private = &s->cl; 592 593 /* 594 * The bucket we're reading from might be reused while our bio 595 * is in flight, and we could then end up reading the wrong 596 * data. 597 * 598 * We guard against this by checking (in cache_read_endio()) if 599 * the pointer is stale again; if so, we treat it as an error 600 * and reread from the backing device (but we don't pass that 601 * error up anywhere). 602 */ 603 604 __bch_submit_bbio(n, b->c); 605 return n == bio ? MAP_DONE : MAP_CONTINUE; 606 } 607 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
