Re: [PATCH 05/26] loop: regularize upgrading the lock size for direct I/O

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
Subject: Re: [PATCH 05/26] loop: regularize upgrading the lock size for direct I/O
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Tue, 11 Jun 2024 12:27:41 -0700
Authentication-results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="EdKe51ZY"
Authentication-results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.12
Authentication-results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org
Authentication-results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org
Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Philipp Reisner <philipp.reisner@xxxxxxxxxx>, Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>, Christoph Böhmwalder <christoph.boehmwalder@xxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Alasdair Kergon <agk@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Mikulas Patocka <mpatocka@xxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yu Kuai <yukuai3@xxxxxxxxxx>, Vineeth Vijayan <vneethv@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-m68k@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, nvdimm@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx
In-reply-to: <20240611051929.513387-6-hch@lst.de>
User-agent: Mozilla Thunderbird

On 6/10/24 10:19 PM, Christoph Hellwig wrote:

The LOOP_CONFIGURE path automatically upgrades the block size to that
of the underlying file for O_DIRECT file descriptors, but the
LOOP_SET_BLOCK_SIZE path does not.  Fix this by lifting the code to
pick the block size into common code.


Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- move features flags into queue_limits
  - From: Christoph Hellwig
- [PATCH 05/26] loop: regularize upgrading the lock size for direct I/O
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 04/26] loop: always update discard settings in loop_reconfigure_limits
Next by Date: Re: [PATCH 06/26] loop: also use the default block size from an underlying block device
Previous by thread: Re: [PATCH 05/26] loop: regularize upgrading the lock size for direct I/O
Next by thread: [PATCH 06/26] loop: also use the default block size from an underlying block device
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux Filesystem Development] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux OMAP] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]