Re: [PATCH 06/26] loop: also use the default block size from an underlying block device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Damien Le Moal <dlemoal@xxxxxxxxxx>
Subject: Re: [PATCH 06/26] loop: also use the default block size from an underlying block device
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 11 Jun 2024 07:59:46 +0200
Authentication-results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211
Authentication-results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de
Authentication-results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de
Cc: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Philipp Reisner <philipp.reisner@xxxxxxxxxx>, Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>, Christoph B??hmwalder <christoph.boehmwalder@xxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Roger Pau Monn?? <roger.pau@xxxxxxxxxx>, Alasdair Kergon <agk@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Mikulas Patocka <mpatocka@xxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yu Kuai <yukuai3@xxxxxxxxxx>, Vineeth Vijayan <vneethv@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-m68k@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, nvdimm@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx
In-reply-to: <27e76310-1831-473e-803a-e0294b91463c@kernel.org>
User-agent: Mutt/1.5.17 (2007-11-01)

On Tue, Jun 11, 2024 at 02:58:56PM +0900, Damien Le Moal wrote:
> > +	if (S_ISBLK(inode->i_mode))
> > +		backing_bdev = I_BDEV(inode);
> > +	else if (inode->i_sb->s_bdev)
> > +		backing_bdev = inode->i_sb->s_bdev;
> > +
> 
> Why not move this hunk inside the below "if" ? (backing_dev declaration can go
> there too).

Because another use will pop up a bit later :)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- move features flags into queue_limits
  - From: Christoph Hellwig
- [PATCH 06/26] loop: also use the default block size from an underlying block device
  - From: Christoph Hellwig
- Re: [PATCH 06/26] loop: also use the default block size from an underlying block device
  - From: Damien Le Moal

Prev by Date: Re: [PATCH 04/26] loop: always update discard settings in loop_reconfigure_limits
Next by Date: Re: [PATCH 07/26] loop: fold loop_update_rotational into loop_reconfigure_limits
Previous by thread: Re: [PATCH 06/26] loop: also use the default block size from an underlying block device
Next by thread: Re: [PATCH 06/26] loop: also use the default block size from an underlying block device
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux Filesystem Development] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux OMAP] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]