On Mon, Jan 22, 2024 at 01:05:28AM +0800, Kuan-Wei Chiu wrote: > On Sun, Jan 21, 2024 at 11:17:30AM -0500, Kent Overstreet wrote: > > On Sun, Jan 21, 2024 at 11:36:46PM +0800, Kuan-Wei Chiu wrote: > > > When dealing with array indices, the parent's index can be obtained > > > using the formula (i - 1) / 2. However, when working with byte offsets, > > > this approach is not straightforward. To address this, we have > > > introduced a branch-free parent function that does not require any > > > division operations to calculate the parent's byte offset. > > > > This is a good commit message - but it would be even better if it was a > > function comment on parent() > > > Sure, however, it seems that sort_cmp_size() can be directly replaced > with the sort function from include/linux. Once we decide on the > cleanup tasks, if we still choose to retain this patch, I will make the > adjustments. nice catch - looks like sort_r() is the more recent addition, so that's how that happened.
