On 1/2/24 8:40 AM, Jens Axboe wrote: > On 1/1/24 6:15 PM, Sergey Senozhatsky wrote: >> On (23/12/28 07:55), Christoph Hellwig wrote: >>> >>> The discard granularity now defaults to a single sector, so don't set >>> that value explicitly >> >> Hmm, but sector size != PAGE_SIZE >> >> [..] >> >>> @@ -2227,7 +2227,6 @@ static int zram_add(void) >>> ZRAM_LOGICAL_BLOCK_SIZE); >>> blk_queue_io_min(zram->disk->queue, PAGE_SIZE); >>> blk_queue_io_opt(zram->disk->queue, PAGE_SIZE); >>> - zram->disk->queue->limits.discard_granularity = PAGE_SIZE; > > Yep, that does indeed look buggy. Ah no it's fine, it'll default to the sector size of the device, which is set before the discard limit/granularity. So should work fine as-is. -- Jens Axboe
