On Wed, Aug 23, 2023 at 12:48:20PM +0200, Jan Kara wrote: > Convert bcache to use bdev_open_by_path() and pass the handle around. > > CC: linux-bcache@xxxxxxxxxxxxxxx > CC: Coly Li <colyli@xxxxxxx > CC: Kent Overstreet <kent.overstreet@xxxxxxxxx> > Acked-by: Christoph Hellwig <hch@xxxxxx> > Acked-by: Coly Li <colyli@xxxxxxx> > Signed-off-by: Jan Kara <jack@xxxxxxx> > --- Looks good to me, Acked-by: Christian Brauner <brauner@xxxxxxxxxx> > - if (!IS_ERR_OR_NULL(dc->bdev)) > - blkdev_put(dc->bdev, dc); > + if (dc->bdev_handle) > + bdev_release(dc->bdev_handle); Fwiw, these conversions confused me a little as the old check gave the impression that this could be set to an error pointer somehow.
