> 2023年7月25日 19:46,Colin Ian King <colin.i.king@xxxxxxxxx> 写道: > > Variable cur_idx is being initialized with a value that is never read, > it is being re-assigned later in a while-loop. Remove the redundant > assignment. Cleans up clang scan build warning: > > drivers/md/bcache/writeback.c:916:2: warning: Value stored to 'cur_idx' > is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx> Looks good to me. Thanks. Reviewed-by: Coly Li <colyli@xxxxxxx> Coly Li > --- > drivers/md/bcache/writeback.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c > index 24c049067f61..c3e872e0a6f2 100644 > --- a/drivers/md/bcache/writeback.c > +++ b/drivers/md/bcache/writeback.c > @@ -913,7 +913,7 @@ static int bch_dirty_init_thread(void *arg) > int cur_idx, prev_idx, skip_nr; > > k = p = NULL; > - cur_idx = prev_idx = 0; > + prev_idx = 0; > > bch_btree_iter_init(&c->root->keys, &iter, NULL); > k = bch_btree_iter_next_filter(&iter, &c->root->keys, bch_ptr_bad); > -- > 2.39.2 >