Coly Li <colyli@xxxxxxx> 于2023年2月3日周五 10:46写道: > > > > > 2023年2月3日 10:43,Zheng Hacker <hackerzheng666@xxxxxxxxx> 写道: > > > > Hello, > > > > After writing the patch, I found there may be more places to replace > > IS_ERR_OR_NULL to IS_ERR. > > If the alloc of node will never be NULL, the additional NULL check of > > nodes after allocation may also > > be useless. This patch just fixes the check around the alloc. I'm not > > sure about other places for my > > limited understanding of the code in bcache. > > This was why I suggested you to post an extra cleanup patch like this. > > You may just add more changes as you mentioned into this patch and post another updated version. > Get it. Will do right now. Thanks, Zheng Wang