Kent, Could you please response this change? It seems to be fine to make these tracepoints static inside bcache, but I am not 100% for your original idea. Thank you in advance. Coly Li > 2022年12月1日 14:32，Christoph Hellwig <hch@xxxxxx> 写道： > > All bcache tracepoints are only used inside of bcache.ko, so there is > no point in exporting them. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > --- > drivers/md/bcache/trace.c | 44 --------------------------------------- > 1 file changed, 44 deletions(-) > > diff --git a/drivers/md/bcache/trace.c b/drivers/md/bcache/trace.c > index a9a73f560c0442..600efecf9bd9de 100644 > --- a/drivers/md/bcache/trace.c > +++ b/drivers/md/bcache/trace.c > @@ -7,47 +7,3 @@ > > #define CREATE_TRACE_POINTS > #include <trace/events/bcache.h> > - > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_request_start); > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_request_end); > - > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_bypass_sequential); > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_bypass_congested); > - > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_read); > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_write); > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_read_retry); > - > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_cache_insert); > - > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_journal_replay_key); > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_journal_write); > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_journal_full); > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_journal_entry_full); > - > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_cache_cannibalize); > - > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_read); > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_write); > - > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_node_alloc); > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_node_alloc_fail); > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_node_free); > - > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_gc_coalesce); > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_gc_start); > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_gc_end); > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_gc_copy); > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_gc_copy_collision); > - > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_insert_key); > - > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_node_split); > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_node_compact); > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_set_root); > - > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_invalidate); > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_alloc_fail); > - > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_writeback); > -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_writeback_collision); > -- > 2.30.2 >
