On 10/20/21 10:13 AM, Lin Feng wrote:
In bcache we have:
./bset.c: pr_notice("loop %u, %llu per us\n", size,
./super.c: pr_notice("error %s: %s\n", dc->backing_dev_name, err);
./super.c: pr_notice("invalidating existing data\n");
./super.c: pr_notice("error %s: %s\n", ca->cache_dev_name, err);
./super.c: pr_notice("error %s: %s\n", ca->cache_dev_name, err);
./super.c: pr_notice("Timeout waiting for devices to be closed\n");
and 3 sites with string 'error' are really error happening on device
register.
It is fine to keep current dmesg level and message format.
Thanks.
Coly Li
Signed-off-by: Lin Feng <linf@xxxxxxxxxx>
---
drivers/md/bcache/super.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index f2874c77ff79..18a2e4bea9c2 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1493,7 +1493,7 @@ static int register_bdev(struct cache_sb *sb, struct cache_sb_disk *sb_disk,
return 0;
err:
- pr_notice("error %s: %s\n", dc->backing_dev_name, err);
+ pr_err("%s: %s\n", dc->backing_dev_name, err);
bcache_device_stop(&dc->disk);
return ret;
}
@@ -2338,7 +2338,7 @@ static int cache_alloc(struct cache *ca)
err_free:
module_put(THIS_MODULE);
if (err)
- pr_notice("error %s: %s\n", ca->cache_dev_name, err);
+ pr_err("%s: %s\n", ca->cache_dev_name, err);
return ret;
}
@@ -2397,7 +2397,7 @@ static int register_cache(struct cache_sb *sb, struct cache_sb_disk *sb_disk,
err:
if (err)
- pr_notice("error %s: %s\n", ca->cache_dev_name, err);
+ pr_err("%s: %s\n", ca->cache_dev_name, err);
return ret;
}
