Re: [PATCH 4/4] bcache: remove bch_crc64_update

[Coly Li <colyli@xxxxxxx>]

On 10/18/21 2:09 PM, Christoph Hellwig wrote:
> bch_crc64_update is an entirely pointless wrapper around crc64_be.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Acked-by: Coly Li <colyli@xxxxxxx>

Thanks.

Coly Li

> ---
>   drivers/md/bcache/btree.c   | 2 +-
>   drivers/md/bcache/request.c | 2 +-
>   drivers/md/bcache/util.h    | 8 --------
>   3 files changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
> index 0595559de174a..93b67b8d31c3d 100644
> --- a/drivers/md/bcache/btree.c
> +++ b/drivers/md/bcache/btree.c
> @@ -141,7 +141,7 @@ static uint64_t btree_csum_set(struct btree *b, struct bset *i)
>   	uint64_t crc = b->key.ptr[0];
>   	void *data = (void *) i + 8, *end = bset_bkey_last(i);
>   
> -	crc = bch_crc64_update(crc, data, end - data);
> +	crc = crc64_be(crc, data, end - data);
>   	return crc ^ 0xffffffffffffffffULL;
>   }
>   
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index 64ce5788f80cb..3f10f82483047 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -46,7 +46,7 @@ static void bio_csum(struct bio *bio, struct bkey *k)
>   	bio_for_each_segment(bv, bio, iter) {
>   		void *d = kmap(bv.bv_page) + bv.bv_offset;
>   
> -		csum = bch_crc64_update(csum, d, bv.bv_len);
> +		csum = crc64_be(csum, d, bv.bv_len);
>   		kunmap(bv.bv_page);
>   	}
>   
> diff --git a/drivers/md/bcache/util.h b/drivers/md/bcache/util.h
> index b64460a762677..6274d6a17e5e7 100644
> --- a/drivers/md/bcache/util.h
> +++ b/drivers/md/bcache/util.h
> @@ -548,14 +548,6 @@ static inline uint64_t bch_crc64(const void *p, size_t len)
>   	return crc ^ 0xffffffffffffffffULL;
>   }
>   
> -static inline uint64_t bch_crc64_update(uint64_t crc,
> -					const void *p,
> -					size_t len)
> -{
> -	crc = crc64_be(crc, p, len);
> -	return crc;
> -}
> -
>   /*
>    * A stepwise-linear pseudo-exponential.  This returns 1 << (x >>
>    * frac_bits), with the less-significant bits filled in by linear