Re: [PATCH 2/9] scsi/sr: add error handling support for add_disk()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Luis Chamberlain <mcgrof@xxxxxxxxxx>
Subject: Re: [PATCH 2/9] scsi/sr: add error handling support for add_disk()
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Sat, 16 Oct 2021 22:53:47 -0400
Authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oracle.com;
Cc: axboe@xxxxxxxxx, jejb@xxxxxxxxxxxxx, martin.petersen@xxxxxxxxxx, agk@xxxxxxxxxx, snitzer@xxxxxxxxxx, colyli@xxxxxxx, kent.overstreet@xxxxxxxxx, boris.ostrovsky@xxxxxxxxxx, jgross@xxxxxxxx, sstabellini@xxxxxxxxxx, roger.pau@xxxxxxxxxx, geert@xxxxxxxxxxxxxx, ulf.hansson@xxxxxxxxxx, tj@xxxxxxxxxx, hare@xxxxxxx, jdike@xxxxxxxxxxx, richard@xxxxxx, anton.ivanov@xxxxxxxxxxxxxxxxxx, johannes.berg@xxxxxxxxx, krisman@xxxxxxxxxxxxx, chris.obbard@xxxxxxxxxxxxx, thehajime@xxxxxxxxx, zhuyifei1999@xxxxxxxxx, haris.iqbal@xxxxxxxxx, jinpu.wang@xxxxxxxxx, miquel.raynal@xxxxxxxxxxx, vigneshr@xxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>
In-reply-to: <20211015233028.2167651-3-mcgrof@kernel.org> (Luis Chamberlain's message of "Fri, 15 Oct 2021 16:30:21 -0700")
Organization: Oracle Corporation

Luis,

> We never checked for errors on add_disk() as this function returned
> void. Now that this is fixed, use the shiny new error handling.
>
> Just put the cdrom kref and have the unwinding be done by
> sr_kref_release().

Acked-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen	Oracle Linux Engineering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH 0/9] block: reviewed add_disk() error handling set
  - From: Luis Chamberlain
- [PATCH 2/9] scsi/sr: add error handling support for add_disk()
  - From: Luis Chamberlain

Prev by Date: Re: [PATCH 1/9] scsi/sd: add error handling support for add_disk()
Next by Date: Re: [PATCH 03/30] bcache: remove bdev_sectors
Previous by thread: [PATCH 2/9] scsi/sr: add error handling support for add_disk()
Next by thread: [PATCH 5/9] xen-blkfront: add error handling support for add_disk()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux Filesystem Development] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux OMAP] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]