On 8/29/21 12:49 PM, Fengfei Xi wrote:
The bi_size is unsigned int type data not less than 0, so we can directly add bi_size without extra judgment Signed-off-by: Fengfei Xi <xi.fengfei@xxxxxxx>
NACK. The check is necessary to avoid redundant and unnecessary memory write.
Coly Li
--- drivers/md/bcache/request.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c index 6d1de889b..2788eec3a 100644 --- a/drivers/md/bcache/request.c +++ b/drivers/md/bcache/request.c @@ -423,9 +423,7 @@ static bool check_should_bypass(struct cached_dev *dc, struct bio *bio) add_sequential(task); i->sequential = 0; found: - if (i->sequential + bio->bi_iter.bi_size > i->sequential) - i->sequential += bio->bi_iter.bi_size; - + i->sequential += bio->bi_iter.bi_size; i->last = bio_end_sector(bio); i->jiffies = jiffies + msecs_to_jiffies(5000); task->sequential_io = i->sequential;
