Re: Ask help for code review (was Re: [PATCH 03/14] bcache: add initial data structures for nvm pages)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Huang, Ying" <ying.huang@xxxxxxxxx>
Subject: Re: Ask help for code review (was Re: [PATCH 03/14] bcache: add initial data structures for nvm pages)
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 23 Jun 2021 09:04:05 +0200
Cc: Coly Li <colyli@xxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Jan Kara <jack@xxxxxxxx>, Hannes Reinecke <hare@xxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, linux-bcache@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, Jianpeng Ma <jianpeng.ma@xxxxxxxxx>, Qiaowei Ren <qiaowei.ren@xxxxxxxxx>, axboe@xxxxxxxxx
In-reply-to: <87czsdhy0u.fsf@yhuang6-desk2.ccr.corp.intel.com>
User-agent: Mutt/1.5.17 (2007-11-01)

Storing a pointer on-media is completely broken.  It is not endian
clean, not 32-bit vs 64-bit clean and will lead to problems when addresses
change.  And they will change - maybe not often with DDR-attached
memory, but very certainly with CXL-attached memory that is completely
hot pluggable.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: Ask help for code review (was Re: [PATCH 03/14] bcache: add initial data structures for nvm pages)
  - From: Coly Li

References:
- [PATCH 00/14] bcache patches for Linux v5.14
  - From: Coly Li
- [PATCH 03/14] bcache: add initial data structures for nvm pages
  - From: Coly Li
- Ask help for code review (was Re: [PATCH 03/14] bcache: add initial data structures for nvm pages)
  - From: Coly Li
- Re: Ask help for code review (was Re: [PATCH 03/14] bcache: add initial data structures for nvm pages)
  - From: Huang, Ying
- Re: Ask help for code review (was Re: [PATCH 03/14] bcache: add initial data structures for nvm pages)
  - From: Coly Li
- Re: Ask help for code review (was Re: [PATCH 03/14] bcache: add initial data structures for nvm pages)
  - From: Huang, Ying

Prev by Date: Re: Ask help for code review (was Re: [PATCH 03/14] bcache: add initial data structures for nvm pages)
Next by Date: Re: [PATCH 03/14] bcache: add initial data structures for nvm pages
Previous by thread: Re: Ask help for code review (was Re: [PATCH 03/14] bcache: add initial data structures for nvm pages)
Next by thread: Re: Ask help for code review (was Re: [PATCH 03/14] bcache: add initial data structures for nvm pages)
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux Filesystem Development] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux OMAP] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]