On 6/23/21 1:46 PM, Pavel Goran wrote: > Hello Coly, > > Wednesday, June 23, 2021, 12:35:21 PM, you wrote: > >> ... (skipped a lot) >>>> + /* recs array can has hole */ >>> can have holes ? >> It means the valid record is not always continuously stored in recs[] >> from struct bch_nvm_pgalloc_recs. Because currently only 8 bytes write >> to a 8 bytes aligned address on NVDIMM is stomic for power failure. >> ... > The issue is with the wording of this comment, not with the code or the > meaning of the comment. > > The comment should read "recs array can have hole". Oh, I see. Thank Pavel for the hint :-) We will update it in next post. Coly Li
