On 4/12/21 5:06 PM, Christoph Hellwig wrote: > On Sun, Apr 11, 2021 at 09:43:16PM +0800, Coly Li wrote: >> The patch "bcache: remove PTR_CACHE" introduces a compiling failure in >> debug.c with following error message, >> In file included from drivers/md/bcache/bcache.h:182:0, >> from drivers/md/bcache/debug.c:9: >> drivers/md/bcache/debug.c: In function 'bch_btree_verify': >> drivers/md/bcache/debug.c:53:19: error: 'c' undeclared (first use in >> this function) >> bio_set_dev(bio, c->cache->bdev); >> ^ >> This patch fixes the regression by replacing c->cache->bdev by b->c-> >> cache->bdev. > > Why not fold this into the offending patch? > I don't know whether I can do it without authorization or agreement from original author. And I see other maintainers handling similar situation by either re-write whole patch or appending an extra fix. If you have a suggested process, I can try it out next time for similar situation. Coly Li
