Re: [RFC PATCH v6 0/7] nvm page allocator for bcache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/9/21 10:30 AM, Ren, Qiaowei wrote:
> 
>> -----Original Message-----
>> From: Coly Li <colyli@xxxxxxx>
>> Sent: Monday, February 8, 2021 9:50 PM
>> To: Ren, Qiaowei <qiaowei.ren@xxxxxxxxx>; Ma, Jianpeng
>> <jianpeng.ma@xxxxxxxxx>
>> Cc: linux-bcache@xxxxxxxxxxxxxxx
>> Subject: Re: [RFC PATCH v6 0/7] nvm page allocator for bcache
>>
>> On 2/8/21 10:26 PM, Qiaowei Ren wrote:
>>> This series implements nvm pages allocator for bcache. This idea is
>>> from one discussion about nvdimm use case in kernel together with
>>> Coly. Coly sent the following email about this idea to give some
>>> introduction on what we will do before:
>>>
>>> https://lore.kernel.org/linux-bcache/bc7e71ec-97eb-b226-d4fc-d8b64c1ef
>>> 41a@xxxxxxx/
>>>
>>> Here this series focus on the first step in above email, that is to
>>> say, this patch set implements a generic framework in bcache to
>>> allocate/release NV-memory pages, and provide allocated pages for each
>> requestor after reboot.
>>> In order to do this, one simple buddy system is implemented to manage
>>> NV-memory pages.
>>>
>>> This set includes one testing module which can be used for simple test
>> cases.
>>> Next need to stroe bcache log or internal btree nodes into nvdimm
>>> based on these buddy apis to do more testing.
>>>
>>> Qiaowei Ren (7):
>>>   bcache: add initial data structures for nvm pages
>>>   bcache: initialize the nvm pages allocator
>>>   bcache: initialization of the buddy
>>>   bcache: bch_nvm_alloc_pages() of the buddy
>>>   bcache: bch_nvm_free_pages() of the buddy
>>>   bcache: get allocated pages from specific owner
>>>   bcache: persist owner info when alloc/free pages.
>>
>> I test the V6 patch set, it works with current bcache part change. Sorry for
>> not response for the previous series in time on list, but thank you all to fix
>> the known issues in previous version.
>>
>> Although the series is still marked as RFC patches, but IMHO they are in good
>> shape for an EXPERIMENTAL series.
>>
>> I will have them with my other bcache changes in the v5.12 for-next, and it is
>> so far so good in my smoking testing.
>>
>> There is one thing I feel should be clarified from you, I see some patches the
>> author and the first signed-off-by person is not identical.
>> Please make the first SOB people to be the same one in the From/Author
>> field. And I guess maybe most of the work are done by both of you, if this is
>> true, the second author can use a Co-authored-by: tag after the first Signed-
>> off-by: person.
>>
> Yes, it is true, but the From/Author field should be Jianpeng. Thanks.

OK, I will modify from my side, you don't need to post one more version
for this.

[snipped]

Thanks.

Coly Li




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux ARM Kernel]     [Linux Filesystem Development]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux