But the old code is also completely broken. We can't just OR in the op, as that implicitly assumes the old op was 0 (REQ_OP_READ). Please fix this to explicitly set the exact op and flags that you want instead of this fragile magic.
But the old code is also completely broken. We can't just OR in the op, as that implicitly assumes the old op was 0 (REQ_OP_READ). Please fix this to explicitly set the exact op and flags that you want instead of this fragile magic.
|