On 12/21/20 11:17 AM, Yi Li wrote: > Trivial fix to bdput. > > Signed-off-by: Yi Li <yili@xxxxxxxxxxx>e Hi Yi, Indeed these two fixes are not that trivial. I suggest to describe more detail about why your fixes are necessary and what problems are fixed by your patches. Thanks. Coly Li > --- > drivers/md/bcache/super.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index f7ad1e26b013..1756f6926098 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -2525,8 +2525,8 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr, > else > err = "device busy"; > mutex_unlock(&bch_register_lock); > - if (!IS_ERR(bdev)) > - bdput(bdev); > + if (!IS_ERR(dev)) > + bdput(dev); > if (attr == &ksysfs_register_quiet) > goto done; > } >