Hello, On Wed, Nov 25, 2020 at 05:29:26PM +0100, Christoph Hellwig wrote: > > I was wondering whether losing the stale bdev flushing in bd_acquire() would > > cause user-visible behavior changes but can't see how it would given that > > userland has no way of holding onto a specific instance of block inode. > > Maybe it's something worth mentioning in the commit message? > > With stale bdev flushing do you mean the call to bd_forget if > i_bdev exists but is unhashed? It doesn't actually flush anything but Yeah. > just detaches the old bdev from the inode so that the new one can be > attached. That problem goes away by definition if we don't attach > the bdev to the inode. Yeah, I think so. Was just wondering whether the problem actually goes away. Thanks. -- tejun