On 11/1/20 3:27 AM, Christoph Hellwig wrote: > On Sat, Oct 31, 2020 at 08:58:52AM -0600, Jens Axboe wrote: >> On 10/31/20 2:58 AM, Christoph Hellwig wrote: >>> -ENOTTY is the convention for "driver does not support this ioctl". >>> Use it properly in mtip32xx instead of the bogys -EINVAL. >> >> While that's certainly true, there is a risk in making a change like this >> years after the fact. Not that I expect there are any mtip32xx users >> left at this point, but... > > -ENOTTY is what most drivers return. That being said we can keep the > old behavior, so if you prepfer that I can respin to do that. Yeah I know that -ENOTTY is what they all should use (and most of course does), just saying that this change carries some risk. Given that mtip32xx can probably be retired in the not-too-distant future, I say we just keep the -EINVAL here. -- Jens Axboe
