Re: [PATCH] bcache: remove unused function closure_set_ret_ip()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




在 2020/9/29 14:49, Coly Li 写道:
On 2020/9/29 14:47, Jason Yan wrote:
This function has no caller after commit e4bf791937d8 ("bcache: Fix,
improve efficiency of closure_sync()").

Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>

NACK. Indeed, it is necessary for closure debug, you don't want to make
current life even worse.


Get it. Thanks.

Jason


Coly Li


---
  drivers/md/bcache/closure.h | 7 -------
  1 file changed, 7 deletions(-)

diff --git a/drivers/md/bcache/closure.h b/drivers/md/bcache/closure.h
index c88cdc4ae4ec..35f3f87f74e4 100644
--- a/drivers/md/bcache/closure.h
+++ b/drivers/md/bcache/closure.h
@@ -205,13 +205,6 @@ static inline void closure_set_ip(struct closure *cl)
  #endif
  }
-static inline void closure_set_ret_ip(struct closure *cl)
-{
-#ifdef CONFIG_BCACHE_CLOSURES_DEBUG
-	cl->ip = _RET_IP_;
-#endif
-}
-
  static inline void closure_set_waiting(struct closure *cl, unsigned long f)
  {
  #ifdef CONFIG_BCACHE_CLOSURES_DEBUG





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux ARM Kernel]     [Linux Filesystem Development]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux