On 2020/8/17 18:28, Christoph Hellwig wrote: > On Sat, Aug 15, 2020 at 12:10:43PM +0800, Coly Li wrote: >> struct cache_sb does not exactly map to cache_sb_disk, it is only for >> in-memory super block and dosn't belong to uapi bcache.h. >> >> This patch moves the struct cache_sb definition and other depending >> macros and inline routines from include/uapi/linux/bcache.h to >> drivers/md/bcache/bcache.h, this is the proper location to have them. > > Honestly, nothing in include/uapi/linux/bcache.h is a UAPI. It seems > to be a random mix of the on-disk format and internals, but certainly > noting that declares a UAPI at all. > > Which might not invalidate this patch, but while you touch it you > should probably add a patch that once only the on-disk format is > left the file gets renamed to say drivers/md/bcache/disk_format.h. > OK then I keep include/uapi/linux/bcache as it is for this moment. Thanks for the comments. Coly Li
