On 3/24/20 8:32 PM, Coly Li wrote:
> On 2020/3/25 9:57 上午, Jens Axboe wrote:
>> On 3/24/20 7:30 PM, Coly Li wrote:
>>> Commit ab544165dc2d ("bcache: move macro btree() and btree_root()
>>> into btree.h") makes two duplicated declaration into btree.h,
>>> typedef int (btree_map_keys_fn)();
>>> int bch_btree_map_keys();
>>>
>>> The kbuild test robot <lkp@xxxxxxxxx> detects and reports this
>>> problem and this patch fixes it by removing the duplicated ones.
>>>
>>> Fixes: ab544165dc2d ("bcache: move macro btree() and btree_root() into btree.h")
>>
>> Applied, but I fixed up the commit sha, not sure where yours is from?
>>
>
> I should use the sha from your tree, not mine. I just realize with your
> SOB the sha number should change. Sorry for the inconvenience, and I
> will notice such condition next time.
>
> BTW, you still find such issue by your own eyes, without any extra tool?
Manual inspection, to try and avoid cases where the sha is either too
short, or just plain wrong.
--
Jens Axboe
