On 10/18/18 8:44 PM, Shenghui Wang wrote:
> debugfs_remove and debugfs_remove_recursive will check if the dentry
> pointer is NULL or ERR, and will do nothing in that case.
>
> Remove the check in cache_set_free and bch_debug_init.
>
> Signed-off-by: Shenghui Wang <shhuiw@xxxxxxxxxxx>
Added to my for-next, thanks.
Coly Li
> ---
> drivers/md/bcache/debug.c | 3 +--
> drivers/md/bcache/super.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/md/bcache/debug.c b/drivers/md/bcache/debug.c
> index 06da66b2488a..8c53d874ada4 100644
> --- a/drivers/md/bcache/debug.c
> +++ b/drivers/md/bcache/debug.c
> @@ -249,8 +249,7 @@ void bch_debug_init_cache_set(struct cache_set *c)
>
> void bch_debug_exit(void)
> {
> - if (!IS_ERR_OR_NULL(bcache_debug))
> - debugfs_remove_recursive(bcache_debug);
> + debugfs_remove_recursive(bcache_debug);
> }
>
> void __init bch_debug_init(struct kobject *kobj)
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 30ba9aeb5ee8..6695635cdefc 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -1507,8 +1507,7 @@ static void cache_set_free(struct closure *cl)
> struct cache *ca;
> unsigned int i;
>
> - if (!IS_ERR_OR_NULL(c->debug))
> - debugfs_remove(c->debug);
> + debugfs_remove(c->debug);
>
> bch_open_buckets_free(c);
> bch_btree_cache_free(c);
>
