On 8/22/18 12:07 PM, Coly Li wrote: > On 2018/8/23 2:02 AM, Coly Li wrote: >> From: Shan Hai <shan.hai@xxxxxxxxxx> >> >> The writeback thread would exit with a lock held when the cache device is >> detached via sysfs interface, fix it by releasing the held lock before exiting >> the while-loop. >> >> Fixes: fadd94e05c02 (bcache: quit dc->writeback_thread when BCACHE_DEV_DETACHING is set) >> Signed-off-by: Shan Hai <shan.hai@xxxxxxxxxx> >> Signed-off-by: Coly Li <colyli@xxxxxxx> >> Tested-by: Shenghui Wang <shhuiw@xxxxxxxxxxx> >> Cc: stable@xxxxxxxxxxxxxxx #4.17+ >> --- >> Changelog: >> v2: add Fixes tag by Coly Li. >> v1: initial patch from Shan Hai. > > Hi Jens, > > Please pick this patch for your next pull request. The change from Shan > Hai fixes a real issue which is reported and lately verified by Shenghui > Wang. Applied - but I fixed up the commit message. Please keep lines at 72 characters for git commits. -- Jens Axboe