Re: [PATCH] bcache: parameter not in use

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2018/8/10 3:48 PM, Dongbo Cao wrote:
> parameter "struct kobject *kobj" in function "bch_debug_init" is not in use
> 
> Signed-off-by: Dongbo Cao <cdbdyx@xxxxxxx>

It is good for me. I pick it for my for-next, with a minor rebase
against Jens' for-next.

Thanks.

Coly Li

> ---
>  drivers/md/bcache/bcache.h | 2 +-
>  drivers/md/bcache/debug.c  | 2 +-
>  drivers/md/bcache/super.c  | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/md/bcache/bcache.h b/drivers/md/bcache/bcache.h
> index d6bf294f..7308f7d9 100644
> --- a/drivers/md/bcache/bcache.h
> +++ b/drivers/md/bcache/bcache.h
> @@ -995,7 +995,7 @@ void bch_open_buckets_free(struct cache_set *);
>  int bch_cache_allocator_start(struct cache *ca);
>  
>  void bch_debug_exit(void);
> -int bch_debug_init(struct kobject *);
> +int bch_debug_init(void);
>  void bch_request_exit(void);
>  int bch_request_init(void);
>  
> diff --git a/drivers/md/bcache/debug.c b/drivers/md/bcache/debug.c
> index d030ce30..b0e09c18 100644
> --- a/drivers/md/bcache/debug.c
> +++ b/drivers/md/bcache/debug.c
> @@ -248,7 +248,7 @@ void bch_debug_exit(void)
>  		debugfs_remove_recursive(bcache_debug);
>  }
>  
> -int __init bch_debug_init(struct kobject *kobj)
> +int __init bch_debug_init(void)
>  {
>  	if (!IS_ENABLED(CONFIG_DEBUG_FS))
>  		return 0;
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index fa4058e4..f98352d4 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -2327,7 +2327,7 @@ static int __init bcache_init(void)
>  	if (!(bcache_wq = alloc_workqueue("bcache", WQ_MEM_RECLAIM, 0)) ||
>  	    !(bcache_kobj = kobject_create_and_add("bcache", fs_kobj)) ||
>  	    bch_request_init() ||
> -	    bch_debug_init(bcache_kobj) || closure_debug_init() ||
> +	    bch_debug_init() || closure_debug_init() ||
>  	    sysfs_create_files(bcache_kobj, files))
>  		goto err;
>  
> 




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux ARM Kernel]     [Linux Filesystem Development]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux