On 2018/8/6 12:04 AM, Ben Peddell wrote:
> Forgot to include the maintainers with my first email.
>
> Somewhere between Michael Lyle's original
> "bcache: PI controller for writeback rate V2" patch dated 07 Sep 2017
> and 1d316e6 bcache: implement PI controller for writeback rate,
> the mapping of the writeback_rate_minimum attribute was dropped.
>
> Re-add the missing sysfs writeback_rate_minimum attribute mapping to
> "allow the user to specify a minimum rate at which dirty blocks are
> retired."
>
> Fixes: 1d316e6 bcache: implement PI controller for writeback rate
> Signed-off-by: Ben Peddell <klightspeed@xxxxxxxxxxxxxxxx>
>
Also CC Michael, he is the author of new PI controller.
Thanks.
Coly Li
> ---
> drivers/md/bcache/sysfs.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
> index 225b15aa0340..34819f2c257d 100644
> --- a/drivers/md/bcache/sysfs.c
> +++ b/drivers/md/bcache/sysfs.c
> @@ -263,6 +263,7 @@ STORE(__cached_dev)
> 1, WRITEBACK_RATE_UPDATE_SECS_MAX);
> d_strtoul(writeback_rate_i_term_inverse);
> d_strtoul_nonzero(writeback_rate_p_term_inverse);
> + d_strtoul_nonzero(writeback_rate_minimum);
>
> sysfs_strtoul_clamp(io_error_limit, dc->error_limit, 0, INT_MAX);
>
> @@ -389,6 +390,7 @@ static struct attribute *bch_cached_dev_files[] = {
> &sysfs_writeback_rate_update_seconds,
> &sysfs_writeback_rate_i_term_inverse,
> &sysfs_writeback_rate_p_term_inverse,
> + &sysfs_writeback_rate_minimum,
> &sysfs_writeback_rate_debug,
> &sysfs_errors,
> &sysfs_io_error_limit,
>
--
To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
