On 2018/5/22 6:01 PM, Kent Overstreet wrote: > Postgresql is under its own license, which is basically the BSD > license under a different name. > > I don't know if there's precedent for calling that BSD or if you > should just say the postgresql license. > Oh, I just realize the original code is PostgreSQL license. So we cannot export the symbols by EXPORT_SYMBOL_GPL(). Add Linux kernel requires lib/crc64.c has a license statement by MODULE_LICENSE(), and I don't see anywhere else uses MODULE_LICENSE("PostgreSQL"). So I need to ask help from lawyers, and for this moment I will hold related patches for 4.18. Thanks. > On Tue, May 22, 2018 at 5:55 AM, Coly Li <colyli@xxxxxxx> wrote: >> On 2018/5/22 5:53 PM, Andy Shevchenko wrote: >>> On Tue, 2018-05-22 at 17:01 +0800, Coly Li wrote: >>>> On 2018/5/22 4:54 PM, Coly Li wrote: >>>>> This patch adds MODULE_LICENSE("GPL") to remove a kernel build >>>>> warning >>>>> information. Also as Andy Shevchenko suggested, adds a SPDX header >>>>> into >>>>> lib/crc64.c file. >>>>> >>> >>>> Could you please to offer a Reviewed-by or Acked-by ? We have an >>>> agreement that every patch should have a peer reviewer, at this moment >>>> we are lack of code reviewer but I still want to keep this rule as >>>> much >>>> as I can. >>> >>> I would love to, but I'm not a lawyer. I can't do it in _this_ case, >>> sorry. >>> >> >> OK... Then I have to ask someone else to review this patch. >> >> Thanks. >> >> Coly Li >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html