Hi! 2018-05-16 20:05 GMT+02:00 Kai Krakow <kai@xxxxxxxxxxx>: > Hi Coly! > > Before I reboot with the patch applied, it emits a compiler warning you may > want to fix: > > drivers/md/bcache/debug.c:20:23: Warnung: »debug« defined but not used > [-Wunused-variable] > static struct dentry *debug; > ^~~~~ > > See you after reboot. :-) $ uname -a Linux jupiter 4.16.8-ck #3 SMP PREEMPT Wed May 16 20:02:55 CEST 2018 x86_64 Intel(R) Core(TM) i7-3770K CPU @ 3.50GHz GenuineIntel GNU/Linux Mission accomplished! You are great, guys! Thanks, Kai. > 2018-05-16 15:02 GMT+02:00 Coly Li <colyli@xxxxxxx>: >> On 2018/5/16 6:46 PM, Kai Krakow wrote: >>> Hello Kent! >>> >>> 2018-05-16 9:58 GMT+02:00 Kent Overstreet <kent.overstreet@xxxxxxxxx>: >>>> On Wed, May 02, 2018 at 12:53:17PM +0200, Massimo B. wrote: >>>>> Hello, >>>>> >>>>> have you been able to modprobe bcache on 4.16.x? >>>>> I have asked on IRC and it seemed nobody tried before, just me. >>>>> So nobody was able to confirm or confirm against... >>>>> >>>>> https://github.com/dracutdevs/dracut/issues/393 >>>>> At least here I'm not able to modprobe the bcache module from an initramfs. >>>>> So I can't boot with that 4.16.x kernel as my root fs is on bcache. >>>> >>>> It was busted by 539d39eb27083405b82b9e604e88af01a9a46c63 (bcache: fix wrong >>>> return value in bch_debug_init()) - only breaks when CONFIG_DEBUG_FS=n >>>> >>>> also, that commit has a bunch of other unrelated changes in it... >>> >>> Thanks for the pointer, this sounds promising. Do you suggest to remove >>> the unrelated changes, or do you suggest to revert the change in >>> bch_debug_init()? >>> >>> I'll try to fiddle around with this commit this evening. >> >> Hi Massimo, Kai, >> >> Could you please to have a try with the attached patch ? This is a >> rebased version for 4.16.9, I verified it with a kernel has no debugfs >> enabled. Hope it works on your kernels. >> >> If the patches works for you all, I will post patches to 4.17 and >> 4.16-stable both. >> >> Thanks. >> >> Coly Li -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
