From: Tang Junhui <tang.junhui@xxxxxxxxxx>
Hello, Matthias
Sorry for the later reply, I have reproduced this issue,
I found s->iop.bio became invalid after calling bio_complete()
in search_free(). Maybe its upper layer's faulty, since bio should
not freed before we calling bio_put(), but we'd better calling
bio_put() first before calling bio_complete() to notify upper layer
ending this bio.
Please apply this patch add test again to see if this issue still
exist.
Signed-off-by: Tang Junhui <tang.junhui@xxxxxxxxxx>
---
drivers/md/bcache/request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
index 643c3021..eb4e305 100644
--- a/drivers/md/bcache/request.c
+++ b/drivers/md/bcache/request.c
@@ -637,11 +637,11 @@ static void do_bio_hook(struct search *s, struct bio *orig_bio)
static void search_free(struct closure *cl)
{
struct search *s = container_of(cl, struct search, cl);
- bio_complete(s);
if (s->iop.bio)
bio_put(s->iop.bio);
+ bio_complete(s);
closure_debug_destroy(cl);
mempool_free(s, s->d->c->search);
}
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
