On 01/03/2018 03:03 PM, Coly Li wrote: > Bcache only does recoverable I/O for read operations by calling > cached_dev_read_error(). For write opertions there is no I/O recovery for > failed requests. > > But in bch_count_io_errors() no matter read or write I/Os, before errors > counter reaches io error limit, pr_err() always prints "IO error on %, > recoverying". For write requests this information is misleading, because > there is no I/O recovery at all. > > This patch adds a parameter 'is_read' to bch_count_io_errors(), and only > prints "recovering" by pr_err() when the bio direction is READ. > > Signed-off-by: Coly Li <colyli@xxxxxxx> > --- > drivers/md/bcache/bcache.h | 2 +- > drivers/md/bcache/io.c | 13 +++++++++---- > drivers/md/bcache/super.c | 4 +++- > drivers/md/bcache/writeback.c | 4 +++- > 4 files changed, 16 insertions(+), 7 deletions(-) > Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
