On 12/27/2017 07:22 PM, tang.junhui@xxxxxxxxxx wrote: > From: Tang Junhui <tang.junhui@xxxxxxxxxx> > > I remember I have reviewed this patch befor, still there is a bug > in keys_contiguous(), since KEY_OFFSET(key) stores the end adress of the > request IO, so I think we should judge the contiguous of keys as bellow: > if (bkey_cmp(&first->key, &START_KEY(&second->key)) > return false; > Since bkey_cmp() also has judged the KEY_INODE(), so I think we can remove > the KEY_INODE() judement. > > Acctually, we can totally use bkey_cmp to replace keys_contiguous(). This is a good point, thanks! I'll fix & resend tomorrow. Mike -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
